Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keyboard shortcuts #637

Merged
merged 23 commits into from
Jul 1, 2020
Merged

Add keyboard shortcuts #637

merged 23 commits into from
Jul 1, 2020

Conversation

WithoutPants
Copy link
Collaborator

Resolves #81 (with caveats, see below).

Keyboard shortcuts are documented in the manual page.

Note: this PR does not include shortcuts for selecting fields (set scene performer, tags, etc). I will open a new issue covering this deficiency, as I was unable to work out how to do it.

Additionally, this includes a new dialog when pasting an image into the edit Movie page, which allows the user to select the image to set:

image

@WithoutPants WithoutPants added the feature Pull requests that add a new feature label Jun 27, 2020
@WithoutPants WithoutPants added this to the Version 0.3.0 milestone Jun 27, 2020
@bnkai
Copy link
Collaborator

bnkai commented Jun 29, 2020

Looks ok.
In the manual page you have the "f" as show filter dialog when in the code is marked as TODO and doesn't work
The "c" create marker doesn't seem to work either ( or i am not using it right :-) )

Is it easy to highlight or underline the chars that are used for shortcuts when in the edit menu or nav panels ?
Something like firefox
firefox_under

@WithoutPants
Copy link
Collaborator Author

Filter shortcut has been fixed, and the marker create shortcut has been corrected in the manual (its n in line with other "new" commands).

I don't think underlining shortcuts is a good approach, since it will lead the user to believe that the shortcuts are Alt+<key> since that is what they have historically meant. I'm averse to highlighting them in other ways since I feel it will detract from the appeal of the interface. If there's a way to do it that doesn't look gross and doesn't mislead the user then I could consider it, but I'm not thinking of any good options at the moment.

@bnkai
Copy link
Collaborator

bnkai commented Jul 1, 2020

Looks ok now.

@WithoutPants WithoutPants merged commit bfeb7d1 into stashapp:develop Jul 1, 2020
Tweeticoats pushed a commit to Tweeticoats/stash that referenced this pull request Feb 1, 2021
* Add documentation
* Fix manual styling
* Add dialog for setting Movie images
* Mention manual in README
@WithoutPants WithoutPants deleted the hotkeys branch February 4, 2021 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Pull requests that add a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] keyboard shortcuts
2 participants