Update gallery view layout and switch libraries #793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests ok and looks good. Can you resolve the conflicts? |
ghost
force-pushed
the
gallery-makeover
branch
from
963bcc4
to
42435e9
Compare
Done |
Tweeticoats
pushed a commit
to Tweeticoats/stash
that referenced
this pull request
Feb 1, 2021
* Update gallery view layout and switch libraries * Tweak gallery grid layout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The gallery library we've used is old and doesn't really work right since it needs width/height of images to lay them out properly. Without dimensions it just looks bad. I've swapped the gallery for flexbin which is just a small scss snippet which does proper image block layout on the fly, which is presumably how it worked at some point.
I also switched out the lightbox library since it was old and deprecated at this point. fslightbox is functionally more or less the same as the old one, but a bit easier to use and with better mobile support.