-
-
Notifications
You must be signed in to change notification settings - Fork 803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Video filters and transforms #826
Video filters and transforms #826
Conversation
311b043
to
c021721
Compare
While I can't see using this myself, this does cool, and works well based on my cursory tests on Chrome, Firefox and Edge. Haven't yet tried on the iPad. I do think that the Filters tab should probably not be the last tab, since that's the customary location for the Edit tab. The addition of this tab also overflows the tab container when the scene has Movies or a Gallery. |
4b89d90
to
edd6b58
Compare
I've re-ordered the panels, and added an aspect ratio correction slider. Still have to consider the issue of the overflow. |
Any suggestions on handling the overflow? |
This will make it so that the overflow menu and the O-Counter button break together to the next line if needed. That's good enough for me. |
edd6b58
to
e2e1b18
Compare
…ure/video_filters_and_transforms Fix conflicting imports of react-boostrap. Conflicts: ui/v2.5/src/components/Scenes/SceneDetails/Scene.tsx
WIP in progress for review.
I've added css/svg based video filters to the scene player.
The video filters don't work across all browsers. Chrome is the closest to being fully functional, however an issue occurs when mixing an svg filter with a scale/rotate transformation. Firefox on the other hand is laggy with most filters and a decent sized video.