Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scraper list page #833

Merged
merged 4 commits into from
Oct 13, 2020
Merged

Conversation

WithoutPants
Copy link
Collaborator

Adds a Scrapers page to the Settings list.

image
image

Shows each scraper, the scraping types that it supports, and the URL fragments that it matches. List is divided into scene, performer and movie scrapers. Also has a reload scrapers button.

@WithoutPants WithoutPants added the feature Pull requests that add a new feature label Oct 8, 2020
@WithoutPants WithoutPants added this to the Version 0.4.0 milestone Oct 8, 2020
@bnkai
Copy link
Collaborator

bnkai commented Oct 9, 2020

Haven't tested yet.
Looks great and was needed , we get a lot of questions why don't the scene scrapers work in the channel.
A couple of thoughts.

  • Can we get some kind of expandable fields for the scene urls ? The full list of urls for all the scrapers is a lot of pages.

  • The links for the URLs on 90% of the cases will be a 404. eg
    <a href="https://passion-hd.com/video/" class="link" target="_blank" rel="noopener noreferrer">https://passion-hd.com/video/</a>
    While it is very useful for the user to see how he should edit the URL field to get a match reading the anchor text , the href could be changed to only the base url
    something like
    <a href="https://passion-hd.com" class="link" target="_blank" rel="noopener noreferrer">https://passion-hd.com/video/

@WithoutPants
Copy link
Collaborator Author

I've made URL lists over 5 items long collapsible and changed the hrefs. Long URL lists now have a more/less button to expand/collapse the lists.

@WithoutPants WithoutPants merged commit 12cba97 into stashapp:develop Oct 13, 2020
Tweeticoats pushed a commit to Tweeticoats/stash that referenced this pull request Feb 1, 2021
@WithoutPants WithoutPants deleted the scraper-list branch February 4, 2021 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Pull requests that add a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants