Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NewReconcilableHandler should not be used for BackupConfiguration Informer #1404

Open
Legion2 opened this issue Nov 28, 2021 · 1 comment
Open
Labels

Comments

@Legion2
Copy link
Contributor

Legion2 commented Nov 28, 2021

Currently the custom NewReconcilableHandler informer event handler is used to filter the reconciliation events of the BackupConfiguration CR. The "optimization" which only reconciles the BC on changes, has the side effect, that all the resources which are created by the BC (CronJob...) are only updated if the BC is updated. However, if Stash itself is updated to a new version, the BC is not reconciled again resulting in inconsistent configuration for the CronJob resources. In particular, the image version in the CronJob is not updated. Example, I updated to Stash 0.17.0, however the CronJob still uses Stash 0.15.0 container images and the changes introduced in #1396 are not applied to existing CronJobs. However more critical is, that Stash does not reconcile (recreate) the state (CronJob) if someone deleted it, leaving the cluster in an inconsistent state.

Therefore it is better to delete the NewReconcilableHandler and just use a default handler, which periodically reconciles the BC.

c.bcInformer.AddEventHandler(queue.NewReconcilableHandler(c.bcQueue.GetQueue(), core.NamespaceAll))

The current workaround is to delete and recreate the BackupConfiguration

@hossainemruz
Copy link
Contributor

Thank you @Legion2 for reporting the issue. We will look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants