Apply all pod level runtime settings to CronJob #1396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Leon Kiefer <leon.k97@gmx.de>
Legion2
force-pushed
the
cronjob-pod-settings
branch
from
914b9d1 to
b5918de
Compare
hossainemruz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1395
It is not possible to decide which pod level runtime settings make sense for the CronJob, because for each property there is a valid use case, but also there are use cases, where they are not required. There may also be use cases where the CronJob pod settings should be different from those of the Backup Session. This change could also be breaking in case the pod runtime settings of the Backup Configuration contains properties that should not be applied to the CronJob.
As a result, this change should only be seen as workaround and a better solution for configuring the CronJob should be provided in future releases.