Fix conflicting props / data name for columns #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duncanmcclean
approved these changes
Jul 28, 2021
There was a problem hiding this comment.
Thanks! Committed to resolve a conflict with #59.
Out of curiosity, was this causing issues for you or was it just a little thing you noticed while diving through the code? 😅
|
This was causing issues to me on statamic 3.1.29 and i noticed the warning in the console log from Vue. Then i dove into it to discover what was generating it. The issue appeared when trying to choose the columns to show on the index. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Columns is a data name already use by the parent
Listingvue component.Let's rename the prop to
initialColumnsto avoid conflictsRelated Issues