Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add filters support to resources #66

Merged
merged 2 commits into from
Aug 10, 2021
Merged

Add filters support to resources #66

merged 2 commits into from
Aug 10, 2021

Conversation

Skullbock
Copy link
Contributor

@Skullbock Skullbock commented Aug 6, 2021 •
edited by duncanmcclean
Loading

Description

Add Statamic filters support to Runway Resources

Fixes #64

@duncanmcclean
Copy link
Member

Does this PR implement #64?

@Skullbock
Copy link
Contributor Author

Yes i think so. Attaching screenshots

Schermata 2021-08-06 alle 12 41 48

Schermata 2021-08-06 alle 12 41 42

Schermata 2021-08-06 alle 12 41 38

Schermata 2021-08-06 alle 12 41 28

Schermata 2021-08-06 alle 12 41 23

Schermata 2021-08-06 alle 12 41 14

duncanmcclean
duncanmcclean reviewed Aug 6, 2021
View reviewed changes
Copy link
Member

@duncanmcclean duncanmcclean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

Quick question though, is there a way to change the key used in visibleTo to something that's a little more readable, like runway_product or maybe just product?

@Skullbock
Copy link
Contributor Author

I think that's just how statamic passes to us that info. It's the name of the "fake" resource of blueprint.
I'm not yet that familiar with Runway to catch where that's generated. I just "backtracked" it from statamic and saw that it's the name that the action receives...

@duncanmcclean
Copy link
Member

Ah no worries - I've figured out how to change it to runway_resourcename. GitHub's being weird at the moment and won't let me push to your branch so I'll merge this in and make my change.

@duncanmcclean duncanmcclean merged commit a08113e into statamic-rad-pack:2.1 Aug 10, 2021
@duncanmcclean
Copy link
Member

Released in v2.1.6. Thanks again!

@Skullbock
Copy link
Contributor Author

Oh that's great! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duncanmcclean duncanmcclean duncanmcclean left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Filters
2 participants
@Skullbock @duncanmcclean