Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forgot password form tag #2562

Merged
merged 6 commits into from
Sep 30, 2020
Merged

Forgot password form tag #2562

merged 6 commits into from
Sep 30, 2020

Conversation

jesseleite
Copy link
Member

Several improvements to forgot password form tag...

  • Fix broken email_sent / success output.
  • Scope success and error output to message bag so that it plays nice with other forms on page.
  • Clean up code and make consistent with user login and register form tags.

Closes #1777.

@jesseleite jesseleite merged commit 6de0a08 into master Sep 30, 2020
@jesseleite jesseleite deleted the fix-forgot-password-form-tag branch September 30, 2020 18:54
tomhelmer pushed a commit to adaptdk/statamic that referenced this pull request Oct 1, 2020
* Fix forgot password form tag, and make consistent with other user form tags.

* Add test coverage for forgot password form tag.

* Use default laravel success message.

* Translate to pass tests in all Laravel versions.

* Use proper error bag for email validation errors.

* Fix `validateWithBag()` in older versions of Laravel.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sucess notification doesn't show when submiting a forgot password form
1 participant