Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Place entries in structure when localizing #2600

Merged
merged 2 commits into from
Oct 6, 2020
Merged

Place entries in structure when localizing #2600

merged 2 commits into from
Oct 6, 2020

Conversation

jasonvarga
Copy link
Member

Fixes #2471

Includes tests for what was already happening in there, plus new ones for the structure stuff.

@jasonvarga jasonvarga merged commit ad1c9b4 into master Oct 6, 2020
@jasonvarga jasonvarga deleted the fix/2471 branch October 6, 2020 20:51
}

$tree = $structure->in($localized->locale());
$parent = $entry->parent()->in($localized->locale());

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks on pages with no parent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong parent when localizing an entry
2 participants