Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'mount' variable to entries #3040

Closed
wants to merge 1 commit into from
Closed

Add 'mount' variable to entries #3040

wants to merge 1 commit into from

Conversation

duncanmcclean
Copy link
Member

@duncanmcclean duncanmcclean commented Dec 19, 2020

This PR adds in the mount variable to entries to maintain compatibility with v2. This PR implements #1352.

The variable returns a Collection object but maybe it should just return the handle of the associated collection? I'm not sure how it was done in v2.

@jasonvarga
Copy link
Member

Thanks for this but it's not quite the right place for it.

If anything, it should go in the AugmentedEntry class. Returning a collection object would be the right thing to do.

@jasonvarga jasonvarga closed this Dec 21, 2020
@duncanmcclean
Copy link
Member Author

Thanks for this but it's not quite the right place for it.

If anything, it should go in the AugmentedEntry class. Returning a collection object would be the right thing to do.

I had a funny feeling this PR wasn't the right way to go about it 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants