Fix static caching expiry key and re-caching #3085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Firstly, it's easier to maintain. Second, it fixes an issue where the page is re-cached even if the cached version was served.
jasonvarga
force-pushed
the
fix/static-caching-expiration
branch
from
54a296b to
32bc395
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two issues:
It'll now use
expiryas the config key for defining the expiration length for half measure caching.We've documented it that way, and it's nicer than the
default_cache_lengthkey that v2 used.But since the v2 key worked if you dug into the code and worked it out yourself, that'll still work
for backwards compatibility. Calling that deprecated.
Closes #2744
Fixed an issue where the page is re-cached even if the cached version was served. This would extend
the expiration date of the cached page, which could make it appear like the page was cached forever.
This fix also combines the 'retrieve' and 'cache' middlewares.