Fix markdown modifier with custom parser #3373
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there 👋
Just a quick little bug I've noticed.
When creating a custom parser as per the documentation:
And then using this custom parser via the
markdown
modifier:It always uses the
default
markdown parser no matter what option we provide.A quick check at the source code and I found that this check:
always returns
true
since it does not use strict comparison and"any_non_empty_string" == true
.This tiny PR fixes this by making the
in_array
strict.