Ignore redirects when warming or invalidating static cache

[marijoo]

Warming the cache via the static:warm command could result in some failing requests if there are redirect-only entries:

Visiting 78 URLs...
[✗] /a/redirect → cURL error 3:  (see https://curl.haxx.se/libcurl/c/libcurl-errors.html) for /a/redirect
…

This PR fixes this issue by using absoluteUrlWithoutRedirect() instead of absoluteUrl() when collecting entry URLs.

[what-the-diff]

• The absoluteUrl() method was changed to the absoluteUrlWithoutRedirect()

[marijoo]

The problem also appears when invalidating the static cache on entries that are redirects. This will lead to a Server Error right now. That’s why I applied absoluteUrlWithoutRedirect() to DefaultInvalidator, too.

[edalzell]

@marijoo tests are failing, are you able to resolve those?

[marijoo]

Fixed the test case. ✌🏻

[jasonvarga]

I'm not sure this is the behavior we want.

The redirects that are failing - are they redirecting to an external site?

[marijoo]

Nope, all internal redirects.

I wonder why Statamic would want to receive the http response for redirects? For me it seems reasonable to omit those by using absoluteUrlWithoutRedirect().

[aerni]

I agree with @marijoo. I got a template where I redirect to a 404 in certain scenarios. Right now, I'm getting hundreds of failed jobs because of this 😅

[jasonvarga]

A 404, fine, but a regular redirect I'm not sure I understand. You'd want the final URL to be warmed too.

[aerni]

I read this PR again, and I don't quite follow the reasoning either. I'd also expect Statamic to warm the redirects. Except 404.

The only scenario I could see where you wouldn't want this behavior is when you redirect to a page, say /login, which is already warmed because it's part of the pages collection. And now you are trying to warm it as many times as you are redirecting to that page. But maybe Statamic is already smart enough to omit subsequent warmings. Not sure.

[jasonvarga]

I see the issue though.

If an entry is a redirect, $entry->absoluteUrl() would output a non-absolute url. That's what curl error 3 is about. Redirecting to /the-final-url is invalid. It should be http://site.com/the-final-url.

So I'm going to close this PR as it's not the correct approach.

The real issue is that if an entry is a redirect, absoluteUrl() should also return an absolute URL.

title: The Redirect
redirect: /final

$entry->absoluteUrl(); // returns "/final", but should return http://site.com/final

[marijoo]

The real issue is that if an entry is a redirect, absoluteUrl() should also return an absolute URL.

You are absolutelyRight(). I think I found the wrong solution to the right problem. Thanks!

[jasonvarga]

Looks like #7173 is handling this!