Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update key for setting the time limit for half measure caching #294

Closed
wants to merge 1 commit into from
Closed

Update key for setting the time limit for half measure caching #294

wants to merge 1 commit into from

Conversation

jelleroorda
Copy link
Contributor

The documentation for the expiry time for half measure caching seems to be incorrect (outdated?).

You can see this in the ApplicationCacher.php, which inherits it from the parent here: AbstractCacher.php

@jasonvarga
Copy link
Member

Oh that's a bummer.

Looks like I wrote the docs how I wanted it to word but never updated the code.

I'd say this is a bug, or something that should be updated in the code itself. I'd rather you define expiry than default_cache_length. There's no "default". It's just what it is.

@jasonvarga
Copy link
Member

Closing in favor of statamic/cms#2744

@jasonvarga jasonvarga closed this Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants