Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All projects should depend on a central packages.dhall in repo root dir #198

Closed
3 of 4 tasks
epost opened this issue Jun 10, 2019 · 2 comments
Closed
3 of 4 tasks
Assignees
Labels
build build, deploy, CI

Comments

@epost
Copy link
Member

epost commented Jun 10, 2019

Update 2019-08-29: This is now a Spago feature, see here.

TODO: think about whether we want this, now, or whether we should centralise our package defs in another way, because we may be splitting up this monorepo into separate repos.

  • create /packages.dhall
  • gather all package overrides, additions, etc from the various subprojects into that file
  • point spago builds to it
    • make sure Marco's latest stbx-service-rest contributions do the same

Update: tried some of this, but the way I did it leads to nasty cyclic references:

erik@munin:~/dev/statebox/studio/studio (198/central-packages-dhall) $ npm run build

> statebox-studio@1.0.0 build /Users/erik/dev/statebox/studio/studio
> spago build

spago:
↳ ./spago.dhall
  ↳ ./packages.dhall
    ↳ ./../packages.dhall
      ↳ ./../halogen-tree-menu/spago.dhall
        ↳ ./../halogen-tree-menu/packages.dhall

Cyclic import: ../packages.dhall

1:            ../packages.dhall
2:

One workaround may be to not define the Spago-subprojects in their respective subdirs, but to define them in the central /packages.dhall instead. Have to think about whether this is desirable or whether we can come up with something nicer.

WIP notes containing more thoughts on how to do this: https://hackmd.io/NXJG84J9Shirel6KsCrrtA

@epost epost added the build build, deploy, CI label Jun 10, 2019
@epost epost self-assigned this Jun 10, 2019
epost added a commit that referenced this issue Jul 3, 2019
@epost epost changed the title All projects should depend on the same packages.dhall in root dir All projects should depend on a central packages.dhall in repo root dir Aug 28, 2019
@epost
Copy link
Member Author

epost commented Aug 28, 2019

This is now a Spago feature, see mention here purescript/spago#301

@epost
Copy link
Member Author

epost commented Sep 11, 2019

Fixed thanks to new Spago version

@epost epost closed this as completed Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build build, deploy, CI
Projects
None yet
Development

No branches or pull requests

1 participant