add rpc service usage instructions #1236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…jectives nil pointers represent channels that are undefined in the protocol (i.e. a channel left of Alice) These remain untouched / unpopulated throughout.
✅ Deploy Preview for nitrodocs canceled.
|
only store id of consensus channels when marshalling virtualdefund objectives
geoknee
approved these changes
Apr 25, 2023
Add deploycontracts flag
The receiver can have AppData = nil. If that's the case, we shouldn't set the AppData = [] on the returned clone.
rather than duplicating that information. This means that things like finalization proofs can be read from the store by other tasks/objectives. This will be important when it comes to handling challenges. Other changes follow from this one, generally reading / writing to V, ensuring V is "related" to the objective (so it is stored alongside). We can reuse many helpers on V so quite a bit of code can be ripped out.
As in the other protocols, when serializing we only retain the channel Id.
This is enabled by the greater harmony of virtualdefund (it now puts more information in an obvious place in the store)
given changes to underlying data structure
This reverts commit be04c6e.
|
Just a heads up that hardhat-docker is no longer required, due to #1235 |
geoknee
reviewed
Apr 27, 2023
readme.md
Outdated
| After the hardhat docker node is running, go-nitro can be started from the root directory with | ||
|
|
||
| ``` | ||
| go run ./... |
There was a problem hiding this comment.
Is this meaningfully different to go run .?
- be good to give a sense of the arguments which may be passed in, or at least point to where that information is (
go run . -help). - let's also point to the
go buildway of doing it, too?
…tory Embed a reference to the underlying virtual channel in`virtualdefund.Objective`
Specify node version for node related CI
added 3 commits
April 28, 2023 11:18
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR adds documentation on requirements for running
main.go.