Skip to content

Commit

Permalink
Fix typo (#434)
Browse files Browse the repository at this point in the history
* Fix typo

* Fix tests

---------

Co-authored-by: Sebastian Tiedtke <sebastiantiedtke@gmail.com>
  • Loading branch information
mimikun and sourishkrout authored Nov 20, 2023
1 parent 0facecf commit 2cd6f0f
Show file tree
Hide file tree
Showing 18 changed files with 19 additions and 19 deletions.
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ It is always best to discuss your plans beforehand, to ensure that your contribu
- Make commits of logical units
- Write [good commit messages](https://cbea.ms/git-commit/)
- Push your changes to a topic branch in your fork of the repository
- As you push your changes, update the pull request with new infomation and tasks as you complete them
- As you push your changes, update the pull request with new information and tasks as you complete them
- Project maintainers might comment on your work as you progress
- When you are done, remove the PR's draft status and ping the maintainers for a review

Expand Down
2 changes: 1 addition & 1 deletion expect/expect.go
Original file line number Diff line number Diff line change
Expand Up @@ -853,7 +853,7 @@ func (e *GExpect) ExpectSwitchCase(cs []Caser, timeout time.Duration) (string, [
if err != nil {
return tbuf.String(), nil, -1, fmt.Errorf("io.Copy failed: %v", err)
}
// timer shoud be reset when new output is available.
// timer should be reset when new output is available.
if nr > 0 {
timer = time.NewTimer(timeout)
}
Expand Down
2 changes: 1 addition & 1 deletion internal/api/runme/runner/v1/runner.proto
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ message ExecuteRequest {
// has no effect in non-interactive mode
optional Winsize winsize = 10;

// background indiciates a background process
// background indicates a background process
// this will send the process' PID as a first response
bool background = 11;

Expand Down
2 changes: 1 addition & 1 deletion internal/auth/auth.go
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ type Auth struct {
// while other can rely on manual copy&paste.
env Env

// loginInProgress is a mutex to prevent concurrect `Login` calls.
// loginInProgress is a mutex to prevent concurrent `Login` calls.
loginInProgress uint32

// loginSession contains details about the current login session.
Expand Down
2 changes: 1 addition & 1 deletion internal/auth/disk_storage_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ func TestDiskStorage(t *testing.T) {
require.Equal(t, expectedToken, token)

// Read from non existing key.
err = ds.Load("invaid-key", &token)
err = ds.Load("invalid-key", &token)
require.ErrorIs(t, err, ErrNotFound)

// Read from invalid path.
Expand Down
2 changes: 1 addition & 1 deletion internal/cmd/auth.go
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ func loginCmd() *cobra.Command {
cmd := &cobra.Command{
Use: "login",
Short: "Log in to Runme (optional)",
Long: "Log in to Runme is not required for standalone funtionality",
Long: "Log in to Runme is not required for standalone functionality",
RunE: func(cmd *cobra.Command, args []string) error {
return newAuth().Login(cmd.Context())
},
Expand Down
2 changes: 1 addition & 1 deletion internal/document/editor/cell.go
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ type Notebook struct {
}

// This mimics what otherwise would happen in the extension
func (n *Notebook) ForceLifecyleIdentities() {
func (n *Notebook) ForceLifecycleIdentities() {
for _, c := range n.Cells {
id, ok := c.Metadata[PrefixAttributeName(InternalAttributePrefix, "id")]
if !ok && id == "" || !ulid.ValidID(id) {
Expand Down
2 changes: 1 addition & 1 deletion internal/document/editor/cell_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -350,7 +350,7 @@ func Test_serializeCells(t *testing.T) {
require.NoError(t, err)

cells := toCells(node, data)
// Add private fields whcih will be filtered out durign serialization.
// Add private fields which will be filtered out durign serialization.
cells[0].Metadata["_private"] = "private"
cells[0].Metadata["runme.dev/internal"] = "internal"

Expand Down
2 changes: 1 addition & 1 deletion internal/gen/proto/go/runme/runner/v1/runner.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion internal/gen/proto/ts/runme/runner/v1/runner_pb.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ export interface ExecuteRequest {
*/
winsize?: Winsize;
/**
* background indiciates a background process
* background indicates a background process
* this will send the process' PID as a first response
*
* @generated from protobuf field: bool background = 11;
Expand Down
2 changes: 1 addition & 1 deletion internal/gen/proto/ts/runme/runner/v1/runner_pb.ts
Original file line number Diff line number Diff line change
Expand Up @@ -642,7 +642,7 @@ export class ExecuteRequest extends Message<ExecuteRequest> {
winsize?: Winsize;

/**
* background indiciates a background process
* background indicates a background process
* this will send the process' PID as a first response
*
* @generated from field: bool background = 11;
Expand Down
2 changes: 1 addition & 1 deletion internal/renderer/testdata/equalvshash.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ The current version looks as follows:

## Best Practices

We have accumulated a set of best practices while developing VSCode extensions. Please note that these are just recommendations, sometimes based on personal preference. There are many ways to write an extension, and we found the following allow you to write them in a scaleable and testable way:
We have accumulated a set of best practices while developing VSCode extensions. Please note that these are just recommendations, sometimes based on personal preference. There are many ways to write an extension, and we found the following allow you to write them in a scalable and testable way:

- [Initiate Extensions through an `ExtensionController`](./docs/ExtensionController.md)
- [Building WebViews](./docs/WebViews.md)
Expand Down
2 changes: 1 addition & 1 deletion internal/runner/command.go
Original file line number Diff line number Diff line change
Expand Up @@ -498,7 +498,7 @@ func (c *command) ProcessWait() error {
return errors.WithStack(c.cmd.Wait())
}

// Finalize performs necassary actions and cleanups after the process exits.
// Finalize performs necessary actions and cleanups after the process exits.
func (c *command) Finalize() (err error) {
if c.cmd.ProcessState == nil {
return errors.New("process not finished")
Expand Down
2 changes: 1 addition & 1 deletion internal/runner/command_windows.go
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ func setSysProcAttrCtty(cmd *exec.Cmd) {}
func setSysProcAttrPgid(cmd *exec.Cmd) {}

func disableEcho(fd uintptr) error {
return errors.New("Error: Environtment not supported! " +
return errors.New("Error: Environment not supported! " +
"Runme currently doesn't support PowerShell. " +
"Please go to https://github.com/stateful/runme/issues/173 to follow progress on this " +
"and join our Discord server at https://discord.gg/runme if you have further questions!")
Expand Down
2 changes: 1 addition & 1 deletion internal/runner/service_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -467,7 +467,7 @@ func Test_runnerService(t *testing.T) {
})

// ExecuteClientCancel is similar to "ExecuteCloseSendDirection" but the client cancels
// the connection. When running wihout TTY, this and sending ExecuteRequest.stop are
// the connection. When running without TTY, this and sending ExecuteRequest.stop are
// the only ways to interrupt a program.
t.Run("ExecuteClientCancel", func(t *testing.T) {
t.Parallel()
Expand Down
2 changes: 1 addition & 1 deletion pkg/project/formatter.go
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ func Format(files []string, basePath string, flatten bool, formatJSON bool, writ
formatted = buf.Bytes()
} else {
if identityResolver.CellEnabled() {
notebook.ForceLifecyleIdentities()
notebook.ForceLifecycleIdentities()
}

formatted, err = editor.Serialize(notebook)
Expand Down
4 changes: 2 additions & 2 deletions pkg/project/project_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ func Test_directoryGitProject(t *testing.T) {
require.NoError(t, err)

assert.Equal(t, map[string]string{
"SECRET_1": "secret1_overriden",
"SECRET_1": "secret1_overridden",
"SECRET_2": "secret2",
"SECRET_3": "secret3",
}, envs)
Expand Down Expand Up @@ -188,7 +188,7 @@ func Test_directoryBareProject(t *testing.T) {
require.NoError(t, err)

assert.Equal(t, map[string]string{
"SECRET_1": "secret1_overriden",
"SECRET_1": "secret1_overridden",
"SECRET_2": "secret2",
"SECRET_3": "secret3",
}, envs)
Expand Down
2 changes: 1 addition & 1 deletion pkg/project/test_project/.env
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
SECRET_1=secret1_overriden
SECRET_1=secret1_overridden
SECRET_2=secret2

0 comments on commit 2cd6f0f

Please sign in to comment.