Skip to content

Commit

Permalink
Improve debuggability of TestRunnerServiceServerExecute
Browse files Browse the repository at this point in the history
  • Loading branch information
adambabik committed Feb 2, 2024
1 parent 1314454 commit c9607c2
Showing 1 changed file with 1 addition and 6 deletions.
7 changes: 1 addition & 6 deletions internal/runnerv2service/service_execute_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -230,8 +230,6 @@ func TestRunnerServiceServerExecute_Input(t *testing.T) {
_, client := testCreateRunnerServiceClient(t, lis)

t.Run("ContinuousInput", func(t *testing.T) {
t.Parallel()

stream, err := client.Execute(context.Background())
require.NoError(t, err)

Expand Down Expand Up @@ -268,8 +266,6 @@ func TestRunnerServiceServerExecute_Input(t *testing.T) {
})

t.Run("SimulateCtrlC", func(t *testing.T) {
t.Parallel()

stream, err := client.Execute(context.Background())
require.NoError(t, err)

Expand Down Expand Up @@ -314,8 +310,6 @@ func TestRunnerServiceServerExecute_Input(t *testing.T) {
})

t.Run("CloseSendDirection", func(t *testing.T) {
t.Parallel()

stream, err := client.Execute(context.Background())
require.NoError(t, err)

Expand All @@ -341,6 +335,7 @@ func TestRunnerServiceServerExecute_Input(t *testing.T) {

result := <-execResult
// TODO(adamb): This should be a specific gRPC error rather than Unknown.
require.NotNil(t, result.Err)
assert.Contains(t, result.Err.Error(), "signal: interrupt")
assert.Equal(t, 130, result.ExitCode)
})
Expand Down

0 comments on commit c9607c2

Please sign in to comment.