Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[internal/project] DocumentPath in tasks is consistent #467

Closed
adambabik opened this issue Jan 4, 2024 · 1 comment · Fixed by #469
Closed

[internal/project] DocumentPath in tasks is consistent #467

adambabik opened this issue Jan 4, 2024 · 1 comment · Fixed by #469

Comments

@adambabik
Copy link
Collaborator

Recently, we discovered some inconsistencies when observing paths returned from runme ls and runme tui, and more precisely from Project.Load() from the internal/project package.

The special case is when the project is bootstrapped by walking the directory upwards. However, the same thing happens if --project is an absolute path.

There are two options:

  • Always return absolute paths and do post processing by the caller.
  • Always return relative paths; relative to the Project.Root().

cc @sourishkrout

@sourishkrout
Copy link
Member

  • Always return absolute paths and do post processing by the caller.

let's do this please. thank you @adambabik!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants