Restore project flag behavior #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pastuxso
approved these changes
Jan 4, 2024
sourishkrout
force-pushed
the
restore-project-flag-behavior
branch
from
062f255 to
24de324
Compare
sourishkrout
commented
Jan 4, 2024
| @@ -58,7 +58,7 @@ func listCmd() *cobra.Command { | |||
| block := task.CodeBlock | |||
| lines := block.Lines() | |||
| relPath, err := filepath.Rel(getCwd(), task.DocumentPath) | |||
| if err != nil || !isTerminal(io.Out.Fd()) { | |||
There was a problem hiding this comment.
@adambabik removing the tty check for consistency. as mentioned, we'll get an absolute path here when the repo’s worktree is assigned from searching upward for .git. in all other cases the path is relative. i thought about fixing it upstream but it seemed ugly having to reconstruct the fs struct with a relative as opposed to an absolute path.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Empty project flag actually means default to cwd but with find repo upwards whereas non-empty project flag pins the specified dir (without applying find repo upwards).
PS: This matches the behavior of the pre-project-svc implementation.