-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore project flag behavior #465
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,102 @@ | ||
cd nested | ||
exec runme ls | ||
cmp stdout ../gitupwards.txt | ||
! stderr . | ||
|
||
cd .. | ||
exec runme ls --project nested | ||
cmp stdout projectset.txt | ||
! stderr . | ||
|
||
-- .git/config -- | ||
[core] | ||
repositoryformatversion = 0 | ||
filemode = true | ||
bare = false | ||
logallrefupdates = true | ||
ignorecase = true | ||
precomposeunicode = true | ||
-- .git/HEAD -- | ||
ref: refs/heads/main | ||
-- nested/file.md -- | ||
--- | ||
runme: | ||
id: 01HFVTDYA775K2HREH9ZGQJ75B | ||
version: 2.0 | ||
--- | ||
|
||
```sh {"name":"echo"} | ||
$ echo "Hello, runme!" | ||
``` | ||
|
||
It can contain multiple lines too: | ||
|
||
```sh {"interactive":"false"} | ||
$ echo "1" | ||
$ echo "2" | ||
$ echo "3" | ||
``` | ||
-- root.md -- | ||
--- | ||
runme: | ||
id: 01HFVTDBE512K2HREH9ZJGQB57 | ||
version: 2.0 | ||
--- | ||
|
||
It can even run scripting languages: | ||
|
||
```js {"name":"hello-js"} | ||
console.log("Hello, runme, from javascript!") | ||
``` | ||
|
||
And it can even run a cell with a custom interpreter: | ||
|
||
```js {"interpreter":"cat","name":"hello-js-cat"} | ||
console.log("Hello, runme, from javascript!") | ||
``` | ||
|
||
It works with `cd`, `pushd`, and similar because all lines are executed as a single script: | ||
|
||
```sh | ||
temp_dir=$(mktemp -d -t "runme-XXXXXXX") | ||
pushd $temp_dir | ||
echo "hi!" > hi.txt | ||
pwd | ||
cat hi.txt | ||
popd | ||
pwd | ||
``` | ||
|
||
## Go | ||
|
||
It can also execute a snippet of Go code: | ||
|
||
```go | ||
package main | ||
|
||
import ( | ||
"fmt" | ||
) | ||
|
||
func main() { | ||
fmt.Println("Hello from Go, runme!") | ||
} | ||
``` | ||
|
||
## Python | ||
|
||
```python {"interpreter":"python3","name":"hello-python"} | ||
def say_hi(): | ||
print("Hello from Python") | ||
|
||
say_hi() | ||
``` | ||
-- gitupwards.txt -- | ||
NAME FILE FIRST COMMAND DESCRIPTION NAMED | ||
echo file.md echo "Hello, runme!" Yes | ||
hello-js ../root.md console.log("Hello, runme, from javascript!") It can even run scripting languages. Yes | ||
hello-js-cat ../root.md console.log("Hello, runme, from javascript!") And it can even run a cell with a custom interpreter. Yes | ||
hello-python ../root.md def say_hi(): Yes | ||
-- projectset.txt -- | ||
NAME FILE FIRST COMMAND DESCRIPTION NAMED | ||
echo nested/file.md echo "Hello, runme!" Yes |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adambabik removing the tty check for consistency. as mentioned, we'll get an absolute path here when the repo’s worktree is assigned from searching upward for
.git
. in all other cases the path is relative. i thought about fixing it upstream but it seemed ugly having to reconstruct the fs struct with a relative as opposed to an absolute path.