Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect media/mime type and return in Runner response #545

Closed
sourishkrout opened this issue Apr 1, 2024 · 1 comment · Fixed by #549
Closed

Detect media/mime type and return in Runner response #545

sourishkrout opened this issue Apr 1, 2024 · 1 comment · Fixed by #549
Assignees
@adambabik

Comments

@sourishkrout
Copy link
Member

sourishkrout commented Apr 1, 2024 •
edited
Loading

The idea is to buffer initial bytes of the runner to auto-detect (best-effort) the media/mime type associated with the output.

Perhaps using libraries such as https://github.com/gabriel-vasile/mimetype or https://github.com/h2non/filetype or other comparable (haven't tried any of them yet).

This will allow the Notebook client to auto-set the renderer type instead of requiring the user to do it.
@sourishkrout
Copy link
Member Author

Lemme know if you have questions @adambabik. Thx!

@adambabik adambabik mentioned this issue Apr 7, 2024
Merged
sourishkrout added a commit that referenced this issue Apr 9, 2024
@adambabik @sourishkrout
Add mime type in ExecuteResponse in runner service (#549)
48dd275 
Mime type is sent in the first `ExecuteReponse` that contains any
stdout; it is sent only once.

Closes #545

Co-authored-by: Sebastian Tiedtke <sebastiantiedtke@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adambabik adambabik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add mime type in ExecuteResponse in runner service stateful/runme
2 participants
@sourishkrout @adambabik