Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing piece in Runme terminal prototype: rolling up environment variables #551

Closed
sourishkrout opened this issue Apr 9, 2024 · 0 comments · Fixed by #563
Closed

Missing piece in Runme terminal prototype: rolling up environment variables #551

sourishkrout opened this issue Apr 9, 2024 · 0 comments · Fixed by #563
Assignees
@adambabik

Comments

@sourishkrout
Copy link
Member

sourishkrout commented Apr 9, 2024 •
edited
Loading

While not fully baked this VS Code terminal integration with already works pretty well. We likely need a new CommandMode that runs ENV snapshotting before the process quits. However, perhaps there are alternatives?

Here's the simple integration; https://github.com/stateful/vscode-runme/blob/main/src/extension/kernel.ts#L826-L831
@adambabik adambabik mentioned this issue Apr 23, 2024
Merged
adambabik added a commit that referenced this issue May 6, 2024
@adambabik
Implement TerminalCommand and Terminal command mode (#563)
0f8255d 
This change implements a new mode called `TERMINAL`. In this mode, the
server, right after starting the script, writes initial commands that
are responsible for collecting environment variables, which will be
added or deleted to the current session.

The `TERMINAL` mode is supported only in the `v2alpha1` runner.

Fixes #551
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adambabik adambabik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement TerminalCommand and Terminal command mode stateful/runme
2 participants
@sourishkrout @adambabik