Fix goreleaser deprecations #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catdevman
commented
Sep 29, 2023
| @@ -47,11 +47,11 @@ jobs: | |||
| uses: google-github-actions/setup-gcloud@v0 | |||
| - name: Release notes | |||
| run: | | |||
| go run ./cmd/release-notes/main.go -version "${GITHUB_REF_NAME}" > ${{ runner.temp }}/releasenotes | |||
| go run ./cmd/release-notes/main.go -version "${GITHUB_REF_NAME}" -owner "${GITHUB_ACTOR}" > ${{ runner.temp }}/releasenotes | |||
There was a problem hiding this comment.
@sourishkrout I added a new secret... I can revert this but it was basically the only way I could get pass this so it makes the gorelease more flexible for sure.
catdevman
commented
Sep 29, 2023
| - name: Copy to latest | ||
| if: env.pre_release == 'false' | ||
| run: gsutil -m cp "gs://runme-artifacts-41eac6/${{ env.version }}/*" gs://runme-artifacts-41eac6/latest | ||
| run: gsutil -m cp "gs://${{ secrets.GS_BUCKET }}/${{ env.version }}/*" gs://${{ secrets.GS_BUCKET }}/latest |
There was a problem hiding this comment.
@sourishkrout same deal here added a new secret to allow me to be able to run the workflow from my own repo
|
Before I changed the replacements
After removing replacements and using the templating |
|
Thanks for the contribution @catdevman. This looks great! @duvanmonsa can you please take a stab at a review? |
pastuxso
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes Issue 378