Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remaining v2 changes #420

Merged
merged 2 commits into from
Nov 14, 2023
Merged

Remaining v2 changes #420

merged 2 commits into from
Nov 14, 2023

Conversation

pastuxso
Copy link
Collaborator

@pastuxso pastuxso commented Nov 7, 2023 •
edited
Loading

Closes: #409

image

@pastuxso pastuxso changed the title Revert "Revert this commit for v2" JSON Annotations Nov 7, 2023
@pastuxso pastuxso marked this pull request as ready for review November 7, 2023 21:30
@pastuxso pastuxso linked an issue Nov 7, 2023 that may be closed by this pull request
Switch to JSON vs legacy encoding for annotations #409
Closed
@pastuxso pastuxso self-assigned this Nov 7, 2023
Base automatically changed from v2 to main November 7, 2023 23:20
@sourishkrout sourishkrout marked this pull request as draft November 8, 2023 00:08
@sourishkrout
Copy link
Member

Converted to draft, until we're ready to merge.

@pastuxso pastuxso changed the title JSON Annotations [WIP] JSON Annotations Nov 10, 2023
@sourishkrout sourishkrout changed the title [WIP] JSON Annotations [WIP] Remaining v2 changes Nov 13, 2023
@sourishkrout
Copy link
Member

sourishkrout commented Nov 13, 2023 •
edited
Loading

@pastuxso let's rebase this branch and use it to track all remaining changes for v2, including switching

runme/internal/document/identity/resolver.go

Line 20 in fae4f8b

DefaultLifecycleIdentity = UnspecifiedLifecycleIdentity
to All.

@sourishkrout sourishkrout marked this pull request as ready for review November 14, 2023 16:01
@sourishkrout sourishkrout changed the title [WIP] Remaining v2 changes Remaining v2 changes Nov 14, 2023
@sourishkrout sourishkrout self-requested a review November 14, 2023 16:23
sourishkrout
sourishkrout approved these changes Nov 14, 2023
View reviewed changes
Copy link
Member

@sourishkrout sourishkrout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 let's merge.

@sourishkrout sourishkrout merged commit e2b4836 into main Nov 14, 2023
4 checks passed
@sourishkrout sourishkrout deleted the json-annotations branch November 14, 2023 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sourishkrout sourishkrout sourishkrout approved these changes

Assignees

@pastuxso pastuxso

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switch to JSON vs legacy encoding for annotations
2 participants
@pastuxso @sourishkrout