Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds version overwrite protection #435

Merged
merged 5 commits into from
Nov 27, 2023
Merged

Adds version overwrite protection #435

merged 5 commits into from
Nov 27, 2023

Conversation

pastuxso
Copy link
Contributor

@pastuxso pastuxso commented Nov 20, 2023 •
edited
Loading

Related: #429

Adds protection to prevent building a binary with a wrong version.

@pastuxso pastuxso force-pushed the version-overwrite-protection branch 14 times, most recently from f8c0dfd to a47eacd Compare November 20, 2023 21:44
@pastuxso pastuxso marked this pull request as ready for review November 20, 2023 21:52
@pastuxso pastuxso force-pushed the version-overwrite-protection branch 2 times, most recently from 16383f8 to b6980bd Compare November 20, 2023 23:24
@sourishkrout
Copy link
Member

@pastuxso can you fill in a description please

@pastuxso pastuxso mentioned this pull request Nov 21, 2023
Closed
4 tasks
@pastuxso pastuxso linked an issue Nov 21, 2023 that may be closed by this pull request
Lifecycle identity refactor leftovers #429
Closed
4 tasks
@pastuxso pastuxso force-pushed the version-overwrite-protection branch from b6980bd to ccdcba2 Compare November 21, 2023 13:53
sourishkrout
sourishkrout requested changes Nov 23, 2023
View reviewed changes
Copy link
Member

@sourishkrout sourishkrout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment about using a base v1 as fixture since we will likely have more major releases going forward and it makes it more clear that it's a fixture.

@pastuxso pastuxso self-assigned this Nov 26, 2023
sourishkrout
sourishkrout approved these changes Nov 27, 2023
View reviewed changes
Copy link
Member

@sourishkrout sourishkrout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pastuxso can you make it v99.x.x please. It's not inconceivable that we get to v9 in a reasonable amount of time. Otherwise, ready to merge 👍 .

@pastuxso pastuxso force-pushed the version-overwrite-protection branch from 9483646 to 93be69c Compare November 27, 2023 14:57
@pastuxso pastuxso force-pushed the version-overwrite-protection branch from 93be69c to d0b3c1c Compare November 27, 2023 15:14
@pastuxso pastuxso merged commit 0beac1e into main Nov 27, 2023
@pastuxso pastuxso deleted the version-overwrite-protection branch November 27, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sourishkrout sourishkrout sourishkrout approved these changes

Assignees

@pastuxso pastuxso

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lifecycle identity refactor leftovers
2 participants
@pastuxso @sourishkrout