Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify dependency tree in internal/document #483

Merged
merged 2 commits into from
Jan 29, 2024

Conversation

adambabik
Copy link
Collaborator

@adambabik adambabik commented Jan 25, 2024

Highlights:

  • internal/project does not require internal/document/identity; it was unused.
  • Reordered a bunch of imports.
  • IdentityResolver is thread-safe now.

@adambabik adambabik force-pushed the adamb/simplify-document-dependency-tree branch from 39aa359 to bdd015d Compare January 25, 2024 23:50
Copy link
Member

@sourishkrout sourishkrout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM.

Copy link

sonarcloud bot commented Jan 29, 2024

@sourishkrout sourishkrout merged commit 81e29e8 into main Jan 29, 2024
6 checks passed
@sourishkrout sourishkrout deleted the adamb/simplify-document-dependency-tree branch January 29, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants