Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix double quoted expression stmts #488

Merged
merged 2 commits into from
Feb 5, 2024
Merged

Conversation

sourishkrout
Copy link
Member

If it's not a literal, this used to panic. Please see diff.

@sourishkrout
Copy link
Member Author

@adambabik came up while I was throwing "complex" scripts at the API: https://app.runme.dev/cell/cls6b7ufu000rdpzye7yv442h

@@ -0,0 +1,42 @@
export PROJECT_PATH="$( dirname $( cd "$( dirname "${BASH_SOURCE[0]}" )" &> /dev/null && pwd ) )"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sourishkrout are you sure you want to keep this file?

Copy link
Member Author

@sourishkrout sourishkrout Feb 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

internal/command/env_resolver_test.go Outdated Show resolved Hide resolved
Co-authored-by: Adam Babik <a.babik@designfortress.com>
Copy link

sonarcloud bot commented Feb 5, 2024

@sourishkrout sourishkrout merged commit 819d392 into main Feb 5, 2024
6 checks passed
@sourishkrout sourishkrout deleted the expression-in-double-quotes branch February 5, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants