-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix .env which broke as part of moving cmds to the project service #493
Conversation
@adambabik, please lemme know if this fix works for you. Please ignore the code coverage, it's low due to integration vs unit test (not in coverage report). Instead of calling this in the Remote/Local runner's |
@@ -95,7 +99,6 @@ func (r *LocalRunner) newExecutable(task project.Task) (runner.Executable, error | |||
Logger: r.logger, | |||
} | |||
|
|||
// TODO(adamb): what about `r.envs`? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adambabik sounded like you had a hunch here
2f7cdcd
to
7f9ad82
Compare
Quality Gate passedIssues Measures |
@adambabik, please do a retro-review. Going through a review with @pastuxso right now so we can ship a fix quickly. |
@sourishkrout I think it's ok. The way the environment variables are handled in I will send a follow up PR with clean up. |
Please see #492 for details.
Before vs after:
Fixes #492.