breaking(docker): move runme to /opt/bin/ #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pastuxso
changed the title
Move 'runme' executable to '/opt/' directory and set '/opt' as working directory This commit updates the Dockerfiles for Alpine and Ubuntu images to move the 'runme' executable to the '/opt/' directory. Additionally, it sets the '/opt' directory as the working directory for the application. Changes: - Dockerfile.alpine: Moved 'runme' executable to '/opt/' directory and updated entrypoint to '/opt/runme'. - Dockerfile.ubuntu: Moved 'runme' executable to '/opt/' directory and updated entrypoint to '/opt/runme'. Closes: #504
pastuxso
force-pushed
the
fix/docker-images
branch
from
a4888c0 to
3ba10d1
Compare
|
pastuxso
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relocate the runme executable to the
/opt/bindirectory and designate/opt/var/runmeas the working directory. This adjustment prevents crashes resulting from accessing the root filesystem (/) when the image is used outside a multi-stage build.The right way to use the docker image outside multi-stage builds is the following:
Use the default working directory:
docker run -it --volume /your/runbooks:/opt/var/runme statefulhq/runmeChanging the working directory:
docker run -it -w /runbooks --volume /your/runbooks:/runbooks statefulhq/runmePassing the
--projectflag:docker run -it --volume /your/runbooks:/runbooks statefulhq/runme --project /runbooksSample:
Closes: #504
For multi-stage dependants that are using the binary from /runme it will be a breaking change.