Refactor ProgramResolver #513
Conversation
There was a problem hiding this comment.
@sourishkrout watch out for field names changed in runner.proto. There is no new enum values though or deleted/new fields. Status enum is not backward compatible, as STATUS_RESOLVED is the last one.
| ModifiedProgram: true, | ||
| Variables: []ProgramResolverVarResult{ | ||
| { | ||
| Status: ProgramResolverStatusUnresolved, |
There was a problem hiding this comment.
@sourishkrout There are a few changes like this one in these tests, which I hope led to more consistent behaviour.
All variables are unresolved here and:
- If a variable is empty (
export A,export A=,export A="") it is marked asProgramResolverStatusUnresolved. - If there is any unquoted value, it is marked as
ProgramResolverStatusUnresolvedWithMessage. - If there is any quoted value, it is marked as
ProgramResolverStatusUnresolvedWithPlaceholder.
There was a problem hiding this comment.
That's fair. In any case, the extension will likely choose to prompt for ProgramResolverStatusUnresolved with a generic message. 👍
| require.NoError(t, err) | ||
| assert.EqualValues(t, tc.modifiedProgram, buf.String()) | ||
| // In skip mode, all variables will be resolved. | ||
| if tc.result != nil { |
There was a problem hiding this comment.
@sourishkrout I hope I figured this out correctly: when ProgramResolverModeSkipAll, then all variables are marked as resolved and their resolved value is equal to the original value.
| ModifiedProgram: true, | ||
| Variables: []ProgramResolverVarResult{ | ||
| { | ||
| Status: ProgramResolverStatusUnresolved, |
There was a problem hiding this comment.
That's fair. In any case, the extension will likely choose to prompt for ProgramResolverStatusUnresolved with a generic message. 👍
| require.NoError(t, err) | ||
| assert.EqualValues(t, tc.modifiedProgram, buf.String()) | ||
| // In skip mode, all variables will be resolved. | ||
| if tc.result != nil { |
|
Follow up for #512.