Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run cells filtered by category at the document level #516

Merged
merged 4 commits into from
Feb 29, 2024
Merged

Conversation

pastuxso
Copy link
Collaborator

@pastuxso pastuxso commented Feb 26, 2024

This pull request enhances the category-matching functionality within the CLI, optimizing task filtering based on specified categories from the Frontmatter category.

Closes: #369

@pastuxso pastuxso force-pushed the feat/categories branch 4 times, most recently from 12c0c12 to dba1a03 Compare February 26, 2024 21:43
@pastuxso pastuxso marked this pull request as ready for review February 26, 2024 21:51
@pastuxso pastuxso self-assigned this Feb 26, 2024
Copy link
Member

@sourishkrout sourishkrout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍. Also, let's create a follow-up ticket to add doc-level category to the extension, too.

Is it possible to teak the test case to perhaps not use pwd? it looks like there's a difference between shells (bash vs zsh) and test cases fail locally.

            --- stdout
            +++ doc-category.txt
            @@ -1,6 +1,6 @@
              ►  Running task install-solution2...
            -Install solution2 in /private/tmp
            +Install solution2 in /tmp
              ►  ✓ Task install-solution2 exited with code 0
              ►  Running task deploy-solution2...
            -Deploy solution2 in /private/tmp
            +Deploy solution2 in /tmp
              ►  ✓ Task deploy-solution2 exited with code 0

@pastuxso
Copy link
Collaborator Author

@sourishkrout Of course, let me work on it.

Copy link

sonarcloud bot commented Feb 29, 2024

@sourishkrout sourishkrout self-requested a review February 29, 2024 14:05
Copy link
Member

@sourishkrout sourishkrout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@pastuxso pastuxso merged commit c15d119 into main Feb 29, 2024
6 checks passed
@pastuxso pastuxso deleted the feat/categories branch February 29, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Document-level options "category"
2 participants