-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds beta command runme env store snapshot
#532
Conversation
2bcc8d8
to
1bd3a71
Compare
- Env vars naming - Date format - Removes "Create" column
78551e0
to
ee8e042
Compare
runme env store snapshot
@@ -803,8 +816,8 @@ func convertToMonitorEnvStoreResponse(msg *runnerv1.MonitorEnvStoreResponse, sna | |||
OriginalValue: item.Value.Original, | |||
ResolvedValue: item.Value.Resolved, | |||
Status: status, | |||
CreateTime: item.Var.Created.String(), | |||
UpdateTime: item.Var.Updated.String(), | |||
CreateTime: item.Var.Created.Format(time.RFC3339), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sourishkrout let's use the RFC3339 which is more standard for sharing dates through systems and compatible with ISO8601, It was tested with the extension and is working fine.
runme env store snapshot
runme env store snapshot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we "remove" the session injection for now? Don't need it for the demo and it needs more thought.
1fdfa9d
to
69b5139
Compare
Yes, removed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Works. Added some flags.
Likely needs a refactor to use the Runner client interface for non-hidden release which we can do later.
Quality Gate failedFailed conditions |
This PR supports interacting with the MonitorEnvStore in the CLI.
Usage:
runme env store snapshot --tlsdir=<RUNME TLS CERTIFICATES> --address=<RUNME SERVER ADDRESS> --session=<RUNME SESSION ID>
The following variables will be used by default if you don't pass arguments:
RUNME_SESSION
RUNME_SERVER_ADDR
RUNME_TLS_DIR
Example:
runme env store snapshot
Issue: #528