Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shebang++ default interpreter "cat" when language is unknown #568

Merged
merged 17 commits into from
May 10, 2024

Conversation

sourishkrout
Copy link
Member

@sourishkrout sourishkrout commented May 7, 2024

Initial implementation was wrong and didn't stick out due to lack of integration testing.

@sourishkrout sourishkrout requested a review from adambabik May 7, 2024 14:37
@sourishkrout
Copy link
Member Author

Surfaced this bug while fixing the shebang++ feature: #569

@sourishkrout sourishkrout marked this pull request as draft May 7, 2024 14:52
@sourishkrout sourishkrout force-pushed the seb-rv2-sbpp branch 2 times, most recently from 9933708 to 36a88a8 Compare May 8, 2024 13:39
@sourishkrout sourishkrout marked this pull request as ready for review May 8, 2024 14:58
@sourishkrout sourishkrout marked this pull request as draft May 8, 2024 15:33
@sourishkrout sourishkrout marked this pull request as ready for review May 9, 2024 15:33
@sourishkrout sourishkrout requested review from adambabik and removed request for adambabik May 9, 2024 15:37
Copy link

sonarcloud bot commented May 10, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
66.7% Coverage on New Code (required ≥ 70%)

See analysis details on SonarCloud

@sourishkrout sourishkrout merged commit a144659 into main May 10, 2024
5 of 6 checks passed
@sourishkrout sourishkrout deleted the seb-rv2-sbpp branch May 10, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants