Define AI GRPC service to support using AI to generate cells #573
Conversation
|
@sourishkrout PTAL |
There was a problem hiding this comment.
Directionally this looks right to me 👍 .
However, I'm working to get #575 merged so we can have the API definitions all in one place and avoid duplication. Looking to merge the upstream PR before EoD.
If you could go ahead and rebase, and move the ai definitions into api please?
|
@jlewi main line is merged. you'll see that now everything API lives under PS: the pre commit hooks are unhappy with the PR as is. however, once |
I'd suggest to just make it part of Runme's buf module for now. We can work on untangling once we have a working "prototype". |
|
@sourishkrout Thanks for the quick refactor. I've updated the PR to move the ai protos into the pkg/api directory. |
|
The SONAR failure seems unrelated to my changes. The error is |
sourishkrout
force-pushed
the
jlewi/protos
branch
from
9bd717c to
ad72415
Compare
Something with repo secrets permissions since your repos is a fork. Not to worried about this. Sonar is a way for us to monitor code health from a mile high view. |
* Define a GRPC service that will take a RunMe notebook and generate cells to be inserted into that notebook * The gRPC service is being defined in stateful/runme#573 * Define converters to and from RunMe protos to Foyle Protos * Make a copy of RunMe's ULID generator code so we can generate cell ids in the format RunMe expects * RunMe"s ULID generator code is defined in an internal package so we can't just reuse it. * Related to [tn_004.md runme integration](https://github.com/jlewi/foyle/blob/main/tech_notes/tn004_runme.md)
We'd like to use AI to generate cells. In particular, we'd like to support using Foyle to add AI capabilities.
The initial plan is to use a gRPC service to allow RunMe to communicate with Foyle (or potentially other AI services). This proto needs to define that gRPC service.