Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable SONAR scan in PRs created from forks #591

Merged
merged 9 commits into from
Jun 3, 2024
Merged

Disable SONAR scan in PRs created from forks #591

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
edb5c74
Enable all unittests in CI
jlewi May 25, 2024
57c4013
Fix the tests.
jlewi May 25, 2024
44e8f55
Skip flaky test.
jlewi May 25, 2024
1317fdc
Fix lint.
jlewi May 25, 2024
9a1b898
Disable sonar step in forks.
jlewi May 25, 2024
63e123f
Merge remote-tracking branch 'upstream/main' into jlewi/gha
jlewi May 31, 2024
4ba685c
Revert changes to ci.yaml because that's not the problem
jlewi May 31, 2024
f165363
Update internal/runner/service_test.go
jlewi Jun 2, 2024
d4e0bde
Add import
sourishkrout Jun 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,10 @@ jobs:

- name: SonarCloud Scan
uses: SonarSource/sonarcloud-github-action@v2.1.1
# Skip this test if the PR is created from a fork.
# If its created from a fork the PR won't be able to fetch the secrets so
# the step will fail.
if: github.event.pull_request.head.repo.full_name == github.repository
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # Needed to get PR information, if any
SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
3 changes: 3 additions & 0 deletions internal/runner/service_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,6 +347,9 @@ func Test_runnerService(t *testing.T) {
})

t.Run("Input", func(t *testing.T) {
if os.Getenv("RUN_FLAKY") == "" {
jlewi marked this conversation as resolved.
Show resolved Hide resolved
t.Skip("skipping flaky test")
}
t.Parallel()

stream, err := client.Execute(context.Background())
Expand Down
Loading