Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We don't want two Project APIs #629

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Conversation

sourishkrout
Copy link
Member

@sourishkrout sourishkrout commented Jul 6, 2024

Internal tools (cross-repo) depend on this which why it was originally moved under pkg.

If anybody else depends on the old Project APIs, they can file a ticket since we don't make general stability guarantees (yet).

@sourishkrout sourishkrout force-pushed the seb/rm-legacy-prj-loader branch from c6f01ef to adcc963 Compare July 6, 2024 21:16
@sourishkrout sourishkrout requested a review from adambabik July 6, 2024 21:18
Copy link

sonarcloud bot commented Jul 6, 2024

@sourishkrout
Copy link
Member Author

sourishkrout commented Jul 6, 2024

@adambabik, can you please take a look? We should have nuked the old Project API the first time around (irrespective that it lives under pkg).

PS: I'm starting to wonder if we'd be better of moving things out under internal since internal vs pkg sends mixed signals. If we did't have internal we could keep a subset of what's under pkg right now that's limit it to what's truly "stable".

@sourishkrout sourishkrout merged commit 0cf2e62 into main Jul 9, 2024
7 checks passed
@sourishkrout sourishkrout deleted the seb/rm-legacy-prj-loader branch July 9, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants