Fixes runme when it attempts to access unreadable files or directories #646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pastuxso
force-pushed
the
645-runme-attempts-to-access-unreadable-files-or-directories
branch
from
5a5535d to
097e13f
Compare
sourishkrout
reviewed
Aug 7, 2024
pastuxso
force-pushed
the
645-runme-attempts-to-access-unreadable-files-or-directories
branch
from
d5e3662 to
81da0e8
Compare
pastuxso
force-pushed
the
645-runme-attempts-to-access-unreadable-files-or-directories
branch
from
81da0e8 to
8c75900
Compare
adambabik
reviewed
Aug 8, 2024
pastuxso
force-pushed
the
645-runme-attempts-to-access-unreadable-files-or-directories
branch
from
2897caa to
70e97f1
Compare
pastuxso
force-pushed
the
645-runme-attempts-to-access-unreadable-files-or-directories
branch
from
bca13ad to
399c008
Compare
pastuxso
force-pushed
the
645-runme-attempts-to-access-unreadable-files-or-directories
branch
from
399c008 to
3e518a1
Compare
|
@pastuxso is this still in draft since it's gotten two reviews already? |
|
@sourishkrout ready for review. I'll push in a separate branch an attempt to improve test running using a non-root user within Docker. |
This reverts commit 169095f.
|
pastuxso
deleted the
645-runme-attempts-to-access-unreadable-files-or-directories
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handling the os.ErrPermission when an error occurs while trying to read files without proper permissions.
Closes: #645