Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow code blocks to be selectively rendered as markdown #702

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Allow code blocks to be selectively rendered as markdown #702

merged 1 commit into from
Nov 21, 2024

Conversation

sourishkrout
Copy link
Member

This PR allows more control over how code blocks are being rendered.

  1. Introduce new annotation transform which defaults to true. If set to false code blocks will be deserialized as markdown.
  2. Make exception for mermaid in languageID which can be overwritten with transform: true

This unlocks Mermaid diagram support in the notebooks.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

pastuxso
pastuxso approved these changes Nov 21, 2024
View reviewed changes
Copy link
Collaborator

@pastuxso pastuxso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sourishkrout sourishkrout merged commit af42bd5 into main Nov 21, 2024
7 checks passed
@sourishkrout sourishkrout deleted the seb/intro-transform branch November 21, 2024 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pastuxso pastuxso pastuxso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sourishkrout @pastuxso