Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting to let users decide if masked or unmasked should be default #1496

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

sourishkrout
Copy link
Member

@sourishkrout sourishkrout commented Jul 26, 2024

Solves stateful/runme#639.

The new extension setting is runme.app.maskOutputs:

image

@sourishkrout sourishkrout requested a review from jlewi July 26, 2024 20:24
@sourishkrout
Copy link
Member Author

@jlewi lemme know if you want to do the review. If not, @pastuxso can take it.

@sourishkrout sourishkrout force-pushed the seb/option-default-unmasked branch from a08c0a3 to 60bdd73 Compare July 26, 2024 20:26
Copy link

sonarcloud bot commented Jul 26, 2024

@jlewi
Copy link
Contributor

jlewi commented Jul 27, 2024

LGTM.

Thanks for the quick fix.

@sourishkrout sourishkrout merged commit f91193e into main Jul 29, 2024
4 checks passed
@sourishkrout sourishkrout deleted the seb/option-default-unmasked branch July 29, 2024 16:07
@sourishkrout
Copy link
Member Author

Included in Runme's latest pre-release effectively now. It should be stable in the next 24-48 hours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants