-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewire stdio for non-interactive #1763
Conversation
@jlewi, here's a demo. You should be able to run it locally. Merging it still requires more work, though. Stdio.mp4 |
The UX looks great. One question I have for non-interactive cells, if I wanted to programmatically access stderr in order to send it to Foyle, where would I tap into it. Consider the following example
In this case what I'd like to happen is
|
I see, @jlewi. We could employ the same strategy for For
and for
Or combine stdout+stderr into a single |
9b988dc
to
a991d85
Compare
a991d85
to
3ce5cae
Compare
@pastuxso please review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
As @jlewi summarized in stateful/runme#684:
This PR aligns the user experience with the above. Todos:
Btw, this PR does not solve how to include
stderr
into the serialized notebook, as per:We'll handle this in a separate PR (cc @jlewi).