-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Runme logging in output channel #521
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been wanting this for months 🤩 thank you for doing this!
Co-authored-by: Max Stoumen <max@mxs.dev>
Co-authored-by: Max Stoumen <max@mxs.dev>
Co-authored-by: Max Stoumen <max@mxs.dev>
Co-authored-by: Max Stoumen <max@mxs.dev>
Addressed comments and fixed tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forgot to mention one last thing!
fixes #454
This is a simple patch that makes Runme log into an dedicated output channel. I kept it intentionally simple for now as we don't know yet many requirements for our logging. For now, this gives us a central point/module to handle logging. I looked into existing logging package which all seem overkill and came with some issues, e.g. @vscode-logging/logger would print out a JSON blog rather than a simple log line.
Something I would have liked to address but is not possible at the moment:
@mxsdev would this prevent the error reported in the original issue to happen again?
Demo:
Interface: