Fixed tests

packages/core/src/actions/cancel.ts

@@ -33,7 +33,9 @@ function resolveCancel(
 }
 
 function executeCancel(actorScope: AnyActorScope, resolvedSendId: string) {
-  actorScope.system.scheduler.cancel(actorScope.self, resolvedSendId);
+  actorScope.defer(() => {
+    actorScope.system.scheduler.cancel(actorScope.self, resolvedSendId);
+  });
 }
 
 export interface CancelAction<

packages/core/src/actions/raise.ts

@@ -87,14 +87,21 @@ function resolveRaise(
 }
 
 function executeRaise(
-  _actorScope: AnyActorScope,
-  _params: {
+  actorScope: AnyActorScope,
+  params: {
     event: EventObject;
     id: string | undefined;
     delay: number | undefined;
   }
 ) {
-  return;
+  const { event, delay, id } = params;
+  if (typeof delay === 'number') {
+    actorScope.defer(() => {
+      const self = actorScope.self;
+      actorScope.system.scheduler.schedule(self, self, event, delay, id);
+    });
+    return;
+  }
 }
 
 export interface RaiseAction<

packages/core/src/actions/send.ts

@@ -157,8 +157,15 @@ function executeSendTo(
   // this forms an outgoing events queue
   // thanks to that the recipient actors are able to read the *updated* snapshot value of the sender
   actorScope.defer(() => {
-    const { to, event, delay, id: _id } = params;
+    const { to, event, delay, id } = params;
     if (typeof delay === 'number') {
+      actorScope.system.scheduler.schedule(
+        actorScope.self,
+        to,
+        event,
+        delay,
+        id
+      );
       return;
     }
     actorScope.system._relay(
@@ -240,7 +247,7 @@ export function sendTo<
 > {
   if (isDevelopment && executingCustomAction) {
     console.warn(
-      'Custom actions should not call `raise()` directly, as it is not imperative. See https://stately.ai/docs/actions#built-in-actions for more details.'
+      'Custom actions should not call `sendTo()` directly, as it is not imperative. See https://stately.ai/docs/actions#built-in-actions for more details.'
     );
   }
 

packages/core/src/createActor.ts

@@ -8,11 +8,10 @@ import {
   createInitEvent
 } from './eventUtils.ts';
 import { reportUnhandledError } from './reportUnhandledError.ts';
-import { executeAction } from './stateUtils.ts';
 import { symbolObservable } from './symbolObservable.ts';
 import { AnyActorSystem, Clock, createSystem } from './system.ts';
 
-export let executingCustomAction: ((...args: any[]) => void) | false = false;
+export let executingCustomAction: boolean = false;
 
 import type {
   ActorScope,
@@ -186,11 +185,11 @@ export class Actor<TLogic extends AnyActorLogic>
         if (!listeners && !wildcardListener) {
           return;
         }
-        const allListeners = new Set([
+        const allListeners = [
           ...(listeners ? listeners.values() : []),
           ...(wildcardListener ? wildcardListener.values() : [])
-        ]);
-        for (const handler of Array.from(allListeners)) {
+        ];
+        for (const handler of allListeners) {
           handler(emittedEvent);
         }
       },
@@ -207,11 +206,12 @@ export class Actor<TLogic extends AnyActorLogic>
           if (!action.exec) {
             return;
           }
+          const saveExecutingCustomAction = executingCustomAction;
           try {
-            executingCustomAction = action.exec;
-            executeAction(action, this);
+            executingCustomAction = true;
+            action.exec(action.info, action.params);
           } finally {
-            executingCustomAction = false;
+            executingCustomAction = saveExecutingCustomAction;
           }
         };
         if (this._processingStatus === ProcessingStatus.Running) {

packages/core/src/stateUtils.ts

@@ -1566,24 +1566,13 @@ function resolveAndExecuteActionsWithContext(
             : action.params
           : undefined;
 
-    function executeAction() {
-      actorScope.actionExecutor(
-        {
-          type: action.type,
-          info: actionArgs,
-          params: actionParams,
-          exec: resolvedAction
-        },
-        actorScope.self
-      );
-    }
-
     if (!resolvedAction || !('resolve' in resolvedAction)) {
-      executeAction();
-      continue;
-    }
-
-    if (!resolvedAction) {
+      actorScope.actionExecutor({
+        type: action.type,
+        info: actionArgs,
+        params: actionParams,
+        exec: resolvedAction
+      });
       continue;
     }
 
@@ -1604,20 +1593,12 @@ function resolveAndExecuteActionsWithContext(
     }
 
     if ('execute' in builtinAction) {
-      actorScope.actionExecutor(
-        {
-          type: builtinAction.type,
-          info: actionArgs,
-          params,
-          exec: () => {} // noop
-        },
-        actorScope.self
-      );
-      if (actorScope.self._processingStatus === ProcessingStatus.Running) {
-        builtinAction.execute(actorScope, params);
-      } else {
-        actorScope.defer(builtinAction.execute.bind(null, actorScope, params));
-      }
+      actorScope.actionExecutor({
+        type: builtinAction.type,
+        info: actionArgs,
+        params,
+        exec: builtinAction.execute.bind(null, actorScope, params)
+      });
     }
 
     if (actions) {

packages/core/src/system.ts

@@ -6,8 +6,7 @@ import {
   Observer,
   HomomorphicOmit,
   EventObject,
-  Subscription,
-  AnyMachineSnapshot
+  Subscription
 } from './types.ts';
 import { toObserver } from './utils.ts';
 
@@ -17,12 +16,7 @@ interface ScheduledEvent {
   startedAt: number; // timestamp
   delay: number;
   source: AnyActorRef;
-  /**
-   * The target `ActorRef` of the event.
-   *
-   * Can be a `string` (references `snapshot.children[target]`) or an `ActorRef`
-   */
-  target: AnyActorRef | string;
+  target: AnyActorRef;
 }
 
 export interface Clock {
@@ -33,7 +27,7 @@ export interface Clock {
 interface Scheduler {
   schedule(
     source: AnyActorRef,
-    target: AnyActorRef | string,
+    target: AnyActorRef,
     event: EventObject,
     delay: number,
     id: string | undefined
@@ -131,18 +125,7 @@ export function createSystem<T extends ActorSystemInfo>(
         delete timerMap[scheduledEventId];
         delete system._snapshot._scheduledEvents[scheduledEventId];
 
-        const resolvedTarget =
-          typeof target === 'string'
-            ? (source.getSnapshot() as AnyMachineSnapshot).children[target]
-            : target;
-
-        if (!resolvedTarget) {
-          throw new Error(
-            `Actor with id ${typeof target === 'string' ? target : target.sessionId} not found in the system.`
-          );
-        }
-
-        system._relay(source, resolvedTarget, event);
+        system._relay(source, target, event);
       }, delay);
 
       timerMap[scheduledEventId] = timeout;

packages/core/src/types.ts

@@ -2678,7 +2678,4 @@ export type ExecutableActionsFrom<T extends AnyActorLogic> =
         | (string extends TAction['type'] ? never : ToExecutableAction<TAction>)
     : never;
 
-export type ActionExecutor = (
-  actionToExecute: ExecutableActionObject,
-  actorRef: AnyActorRef
-) => void;
+export type ActionExecutor = (actionToExecute: ExecutableActionObject) => void;

packages/core/test/actions.test.ts

@@ -4252,7 +4252,7 @@ describe('actions', () => {
     "Custom actions should not call \`raise()\` directly, as it is not imperative. See https://stately.ai/docs/actions#built-in-actions for more details.",
   ],
   [
-    "Custom actions should not call \`raise()\` directly, as it is not imperative. See https://stately.ai/docs/actions#built-in-actions for more details.",
+    "Custom actions should not call \`sendTo()\` directly, as it is not imperative. See https://stately.ai/docs/actions#built-in-actions for more details.",
   ],
   [
     "Custom actions should not call \`emit()\` directly, as it is not imperative. See https://stately.ai/docs/actions#built-in-actions for more details.",