Upgrade TS to 3.8.3 and simplify transition config types #1103
Conversation
🦋 Changeset is good to goLatest commit: 20de55e We got this. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Have u maybe deleted yarn.lock and regenerated it by doing a fresh install? Changes to yarn.lock seem to be too big for what you have changed in package.jsons . |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 20de55e:
|
| } = getDependencyVersionRange(dependentPkgJSON, nextRelease.name); // Firstly we check if it is a peerDependency because if it is, our dependent bump type needs to be major. | ||
|
|
||
| - if (depTypes.includes("peerDependencies") && nextRelease.type !== "patch" && (!releases.has(dependent) || releases.has(dependent) && releases.get(dependent).type !== "major")) { | ||
| + if (depTypes.includes("peerDependencies") && nextRelease.type === "major" && (!releases.has(dependent) || releases.has(dependent) && releases.get(dependent).type !== "major")) { |
There was a problem hiding this comment.
well - this has existed for a reason :p it allows us to minor-bump XState without major-bumping dependencies its peer-dependent packages
I can bring this patch back later though
There was a problem hiding this comment.
Please do - I was unable to build without following the instructions and removing this patch.
Co-Authored-By: Mateusz Burzyński <mateuszburzynski@gmail.com>
This should also fix the "Type instantiation is excessively deep and possibly infinite." errors. microsoft/TypeScript#37613