Add start() to ActorRef interface

packages/core/src/Actor.ts

@@ -74,7 +74,9 @@ export interface ActorRef<TCurrent, TEvent extends EventObject, TRef = any> {
   // subscribe: Subscribable<TCurrent>['subscribe'];
   current: TCurrent;
   ref: TRef;
+  start: () => void;
   stop: () => void;
+  id: string;
   // subscription?: Unsubscribable;
 }
 
@@ -85,18 +87,24 @@ class ObservableActorRef<TCurrent extends EventObject>
 
   constructor(
     public ref: Subscribable<TCurrent>,
-    parent: ActorRef<any, any>,
-    id: string // TODO: use "system"
-  ) {
-    this.subscription = ref.subscribe(
+    private parent: ActorRef<any, any>,
+    public id: string // TODO: use "system"
+  ) {}
+
+  public start() {
+    this.subscription = this.ref.subscribe(
       (value) => {
-        parent.send(toSCXMLEvent(value, { origin: this }));
+        this.parent.send(toSCXMLEvent(value, { origin: this }));
       },
       (err) => {
-        parent.send(toSCXMLEvent(error(id, err) as any, { origin: this }));
+        this.parent.send(
+          toSCXMLEvent(error(this.id, err) as any, { origin: this })
+        );
       },
       () => {
-        parent.send(toSCXMLEvent(doneInvoke(id) as any, { origin: this }));
+        this.parent.send(
+          toSCXMLEvent(doneInvoke(this.id) as any, { origin: this })
+        );
       }
     );
   }
@@ -124,21 +132,26 @@ class PromiseActorRef<T> implements ActorRef<T | undefined, never, Promise<T>> {
   private canceled = false;
   public current: T | undefined = undefined;
 
-  constructor(public ref: Promise<T>, parent: ActorRef<any, any>, id: string) {
+  constructor(
+    public ref: Promise<T>,
+    private parent: ActorRef<any, any>,
+    public id: string
+  ) {}
+  public start() {
     this.ref.then(
       (response) => {
         if (!this.canceled) {
           this.current = response;
-          parent.send(
-            toSCXMLEvent(doneInvoke(id, response) as any, { origin: this })
+          this.parent.send(
+            toSCXMLEvent(doneInvoke(this.id, response) as any, { origin: this })
           );
         }
       },
       (errorData) => {
         if (!this.canceled) {
-          const errorEvent = error(id, errorData);
+          const errorEvent = error(this.id, errorData);
 
-          parent.send(toSCXMLEvent(errorEvent, { origin: this }));
+          this.parent.send(toSCXMLEvent(errorEvent, { origin: this }));
         }
       }
     );
@@ -171,17 +184,18 @@ class CallbackActorRef<
 
   constructor(
     public ref: InvokeCallback,
-    parent: ActorRef<any, any>,
-    id: string
-  ) {
+    private parent: ActorRef<any, any>,
+    public id: string
+  ) {}
+  public start() {
     const dispose = this.ref(
       (e: TEmitted) => {
         if (this.canceled) {
           return;
         }
 
         this.current = e;
-        parent.send(toSCXMLEvent(e, { origin: this }));
+        this.parent.send(toSCXMLEvent(e, { origin: this }));
       },
       (newListener) => {
         this.receivers.add(newListener);
@@ -191,14 +205,14 @@ class CallbackActorRef<
     if (isPromiseLike(dispose)) {
       dispose.then(
         (resolved) => {
-          parent.send(
-            toSCXMLEvent(doneInvoke(id, resolved) as any, { origin: this })
+          this.parent.send(
+            toSCXMLEvent(doneInvoke(this.id, resolved) as any, { origin: this })
           );
           this.canceled = true;
         },
         (errorData) => {
-          const errorEvent = error(id, errorData);
-          parent.send(toSCXMLEvent(errorEvent, { origin: this }));
+          const errorEvent = error(this.id, errorData);
+          this.parent.send(toSCXMLEvent(errorEvent, { origin: this }));
           // TODO: handle error
           this.canceled = true;
         }
@@ -269,10 +283,12 @@ class ServiceActorRef<TContext, TEvent extends EventObject>
   constructor(
     public ref: ActorLike<State<TContext, TEvent>, TEvent> & {
       state: State<TContext, TEvent>;
-    }
+    },
+    public id: string
   ) {
     this.current = this.ref.state;
-
+  }
+  public start() {
     this.subscription = this.ref.subscribe((state) => {
       this.current = state;
     });
@@ -288,9 +304,10 @@ class ServiceActorRef<TContext, TEvent extends EventObject>
 export function fromService<TContext, TEvent extends EventObject>(
   service: ActorLike<State<TContext, TEvent>, TEvent> & {
     state: State<TContext, TEvent>;
-  }
+  },
+  id: string
 ): ActorRef<State<TContext, TEvent>, TEvent, typeof service> {
-  return new ServiceActorRef<TContext, TEvent>(service);
+  return new ServiceActorRef<TContext, TEvent>(service, id);
   // return new ActorRef(
   //   service.send.bind(service),
   //   service.subscribe.bind(service),

packages/core/src/interpreter.ts

@@ -841,9 +841,8 @@ export class Interpreter<
 
         // Invoked services
         if (activity.type === ActionTypes.Invoke) {
-          const serviceCreator:
-            | ServiceConfig<TContext, TEvent>
-            | undefined = this.machine.options.services
+          const actorCreator: ServiceConfig<TContext, TEvent> | undefined = this
+            .machine.options.services
             ? this.machine.options.services[activity.src]
             : undefined;
 
@@ -854,7 +853,7 @@ export class Interpreter<
               ? activity.autoForward
               : !!activity.forward;
 
-          if (!serviceCreator) {
+          if (!actorCreator) {
             // tslint:disable-next-line:no-console
             if (!IS_PRODUCTION) {
               warn(
@@ -866,13 +865,16 @@ export class Interpreter<
           }
 
           try {
-            const actor = serviceCreator(context, _event.data, {
+            const actor = actorCreator(context, _event.data, {
               parent: this as any,
               id,
               data,
               _event
             });
 
+            // start the actor
+            actor.start();
+
             if (autoForward) {
               this.forwardTo.add(id);
             }
@@ -1134,11 +1136,11 @@ export function spawn<TC, TE extends EventObject>(
 export function spawn(
   entity: Spawnable,
   nameOrOptions?: string | SpawnOptions
-): Actor;
+): ActorRef<any, any>;
 export function spawn(
   entity: Spawnable,
   nameOrOptions?: string | SpawnOptions
-): Actor {
+): ActorRef<any, any> {
   const resolvedOptions = resolveSpawnOptions(nameOrOptions);
 
   return withServiceScope(undefined, (service) => {
@@ -1152,7 +1154,13 @@ export function spawn(
     }
 
     if (service) {
-      return service.spawn(entity, resolvedOptions.name, resolvedOptions);
+      const spawned = service.spawn(
+        entity,
+        resolvedOptions.name,
+        resolvedOptions
+      );
+      spawned.start();
+      return spawned;
     } else {
       return createNullActor(resolvedOptions.name);
     }