Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change order of TContext, TEvent, TStateSchema #1260

Merged
merged 3 commits into from
Jul 2, 2020
Merged

Conversation

davidkpiano
Copy link
Member

This PR makes the order of TContext, TEvent, TStateSchema consistent across the codebase.

@davidkpiano davidkpiano requested a review from Andarist June 28, 2020 22:38
@changeset-bot
Copy link

changeset-bot bot commented Jun 28, 2020

🦋 Changeset is good to go

Latest commit: 8b0608b

We got this.

This PR includes changesets to release 10 packages
Name Type
xstate Major
@xstate/analytics Major
@xstate/graph Major
@xstate/immer Major
@xstate/react Major
@xstate/scxml Patch
@xstate/test Major
@xstate/vue Major
@xstate/viz Patch
@xstate/viz-example Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@davidkpiano davidkpiano changed the base branch from master to next June 28, 2020 22:39
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 28, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8b0608b:

Sandbox Source
brave-kapitsa-qq7rf Configuration
cocky-hoover-n3h9h Configuration

Copy link
Member

@Andarist Andarist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good change 👍

@davidkpiano davidkpiano merged commit f530161 into next Jul 2, 2020
@davidkpiano davidkpiano deleted the v5/generic-order branch July 2, 2020 14:57
@github-actions github-actions bot mentioned this pull request Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants