Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v5] Deprecate in: ... #1443

Merged
merged 4 commits into from
Oct 10, 2020
Merged

[v5] Deprecate in: ... #1443

merged 4 commits into from
Oct 10, 2020

Conversation

davidkpiano
Copy link
Member

For https://github.com/davidkpiano/xstate/projects/1#card-40695477

This PR deprecates the in: ... property for transitions. It is recommended to use stateIn() and stateNotIn() guard creators instead.

@changeset-bot
Copy link

changeset-bot bot commented Sep 8, 2020

🦋 Changeset detected

Latest commit: f42c388

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages
Name Type
xstate Major
@xstate/graph Major
@xstate/immer Major
@xstate/react Major
@xstate/test Major
@xstate/vue Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 8, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9e10660:

Sandbox Source
XState Example Template Configuration
XState React Template Configuration

@davidkpiano davidkpiano requested a review from Andarist September 8, 2020 17:47
@davidkpiano davidkpiano merged commit 206996a into next Oct 10, 2020
@davidkpiano davidkpiano deleted the v5/deprecate-in branch October 10, 2020 16:29
@johtso
Copy link
Contributor

johtso commented Jul 8, 2021

I don't think there is a stateNotIn guard, instead you need to use not(stateIn(...)). I guess it's just the change note that's wrong?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants