[v5] Throw error if initial state is not specified. Fixes #674 #1669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 969a2f4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Andarist
approved these changes
Nov 29, 2020
| @@ -193,6 +193,16 @@ export class StateNode< | |||
| ) | |||
| : EMPTY_OBJECT) as StateNodesConfig<TContext, TEvent, TStateSchema>; | |||
|
|
|||
| if (this.type === 'compound' && !this.config.initial) { | |||
There was a problem hiding this comment.
just a general q: what's your stance regarding dev-only errors? Would it be maybe worth it to remove this branch of code in production?
There was a problem hiding this comment.
Errors are something I'd love to have extracted instead, using a similar solution to: https://github.com/formium/tsdx#error-extraction
Tracked here: https://github.com/davidkpiano/xstate/projects/1#card-50248797
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving this from #1587