-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: @xstate/inspect support umd #3144
Conversation
🦋 Changeset detectedLatest commit: 3334fb4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
CodeSee Review Map:Review in an interactive map View more CodeSee Maps Legend |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 3334fb4:
|
globals: { | ||
react: 'React', | ||
xstate: 'XState', | ||
'@xstate/fsm': 'XStateFSM' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that @xstate/inspect
is using @xstate/fsm
anyhow - not the latter is compatible with the inspect package
'@xstate/fsm': 'XStateFSM' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, fixed.
packages/xstate-inspect/package.json
Outdated
"rollup-plugin-typescript2": "^0.30.0", | ||
"typescript": "^4.5.2", | ||
"ws": "^8.4.0", | ||
"xstate": "*" | ||
}, | ||
"peerDependencies": { | ||
"@types/ws": "^8.0.0", | ||
"ws": "^8.0.0" | ||
"fast-safe-stringify": "^2.0.7", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be moved back to dependencies as the createUmdConfig
should "bundle" this in the final file.
No description provided.