Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: @xstate/inspect support umd #3144

Merged
merged 4 commits into from
Mar 11, 2022
Merged

feat: @xstate/inspect support umd #3144

merged 4 commits into from
Mar 11, 2022

Conversation

lecepin
Copy link
Contributor

@lecepin lecepin commented Mar 11, 2022

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Mar 11, 2022

🦋 Changeset detected

Latest commit: 3334fb4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@xstate/inspect Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ghost
Copy link

ghost commented Mar 11, 2022

CodeSee Review Map:

Review these changes using an interactive CodeSee Map

Review in an interactive map

View more CodeSee Maps

Legend

CodeSee Map Legend

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 11, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3334fb4:

Sandbox Source
XState Example Template Configuration
XState React Template Configuration

globals: {
react: 'React',
xstate: 'XState',
'@xstate/fsm': 'XStateFSM'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that @xstate/inspect is using @xstate/fsm anyhow - not the latter is compatible with the inspect package

Suggested change
'@xstate/fsm': 'XStateFSM'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, fixed.

"rollup-plugin-typescript2": "^0.30.0",
"typescript": "^4.5.2",
"ws": "^8.4.0",
"xstate": "*"
},
"peerDependencies": {
"@types/ws": "^8.0.0",
"ws": "^8.0.0"
"fast-safe-stringify": "^2.0.7",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be moved back to dependencies as the createUmdConfig should "bundle" this in the final file.

@Andarist Andarist merged commit e08030f into statelyai:main Mar 11, 2022
@github-actions github-actions bot mentioned this pull request Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants